[U-Boot] [PATCH 44/48] x86: Add helper code for running from EFI

[Bin Meng]

On Fri, Jul 24, 2015 at 5:03 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Wed, Jul 22, 2015 at 11:49 PM, Simon Glass <sjg at chromium.org> wrote:
>> When U-Boot is running from EFI some of the x86 init is replaced with
>> EFI-specific init. For example, since DRAM has already been set up, we only
>> need to find it, not init it. Add these functions so that boards can easily
>> allow booting from EFI if required.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  arch/x86/lib/Makefile     |   1 +
>>  arch/x86/lib/efi/Makefile |   9 +++
>>  arch/x86/lib/efi/car.S    |  12 ++++
>>  arch/x86/lib/efi/efi.c    | 151 ++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 173 insertions(+)
>>  create mode 100644 arch/x86/lib/efi/Makefile
>>  create mode 100644 arch/x86/lib/efi/car.S
>>  create mode 100644 arch/x86/lib/efi/efi.c
>>
>> diff --git a/arch/x86/lib/Makefile b/arch/x86/lib/Makefile
>> index fb4a73c..3db373c 100644
>> --- a/arch/x86/lib/Makefile
>> +++ b/arch/x86/lib/Makefile
>> @@ -31,6 +31,7 @@ obj-y += bios_interrupts.o
>>  obj-$(CONFIG_CMD_BOOTM) += bootm.o
>>  obj-y  += cmd_boot.o
>>  obj-$(CONFIG_HAVE_FSP) += cmd_hob.o
>> +obj-$(CONFIG_EFI_STUB) += efi/
>>  obj-y  += gcc.o
>>  obj-y  += init_helpers.o
>>  obj-y  += interrupts.o
>> diff --git a/arch/x86/lib/efi/Makefile b/arch/x86/lib/efi/Makefile
>> new file mode 100644
>> index 0000000..a308a0e
>> --- /dev/null
>> +++ b/arch/x86/lib/efi/Makefile
>> @@ -0,0 +1,9 @@
>> +#
>> +# (C) Copyright 2002-2006
>> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
>> +#
>> +# SPDX-License-Identifier:     GPL-2.0+
>> +#
>> +
>> +obj-y += car.o
>> +obj-y += efi.o
>> diff --git a/arch/x86/lib/efi/car.S b/arch/x86/lib/efi/car.S
>> new file mode 100644
>> index 0000000..6dda058
>> --- /dev/null
>> +++ b/arch/x86/lib/efi/car.S
>> @@ -0,0 +1,12 @@
>> +/*
>> + * Copyright (c) 2015 Google, Inc
>> + * Written by Simon Glass <sjg at chromium.org>
>> + *
>> + * SPDX-License-Identifier:    GPL-2.0+
>> + */
>> +
>> +.section .text
>> +
>
> This is not needed.
>

Except this nits,

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

[snip]

Regards,
Bin