[U-Boot] [PATCH] usb: ci_udc: fix request allocation when endpoints are disabled

Marek Vasut marex at denx.de
Fri Jul 24 22:05:55 CEST 2015


On Friday, July 24, 2015 at 05:14:21 PM, Rob Herring wrote:
> The ci_udc driver request allocation assumes that the endpoint descriptor
> pointer is set to retrieve the endpoint number, but that is only true
> when the endpoint is enabled. This results in a NULL ptr dereference
> which for me happens to return 0 value. This causes the EP0 request
> struct to be returned for other endpoints. Some gadget drivers like
> fastboot and USB MS work fine, but ethernet does not.
> 
> Really, the ci_udc driver is the oddball here doing this EP0 special
> case handling Stephen added. All the other drivers alloc/free functions
> are pretty much the same with the only variation being the size of the
> private struct. This could all be consolidated to a common function.
> 
> Signed-off-by: Rob Herring <robh at kernel.org>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Stephen Warren <swarren at nvidia.com>

Applied, thanks!

Best regards,
Marek Vasut


More information about the U-Boot mailing list