[U-Boot] [PATCH v2 2/9] net: tftp: Move tftp.h file from ./net to ./include/net

Wolfgang Denk wd at denx.de
Sat Jul 25 14:24:43 CEST 2015


Dear Lukasz Majewski,

In message <1437811877-13764-3-git-send-email-l.majewski at majess.pl> you wrote:
> This change gives the ability to reuse the <tftp.h> header file by other
> subsystems (like e.g. dfu).
> 
> Without this change compilation error emerges for the legacy update.c file.
> 
> Signed-off-by: Lukasz Majewski <l.majewski at majess.pl>
> 
> ---
> Changes for v2:
> - Move tftp.h from ./include to ./include/net/ directory
> ---
>  include/net/tftp.h | 30 ++++++++++++++++++++++++++++++
>  net/bootp.c        |  2 +-
>  net/net.c          |  2 +-
>  net/rarp.c         |  2 +-
>  net/tftp.c         |  2 +-
>  net/tftp.h         | 30 ------------------------------
>  6 files changed, 34 insertions(+), 34 deletions(-)
>  create mode 100644 include/net/tftp.h
>  delete mode 100644 net/tftp.h

NAK.  Please resubmit and use "-M -C" when generating the patches, so
the renames will be properly detected and not result in a file
deletion and the addition of an (apparently new) file.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unsichtbar macht sich die Dummheit, indem sie immer  größere  Ausmaße
annimmt.                             -- Bertold Brecht: Der Tui-Roman


More information about the U-Boot mailing list