[U-Boot] [PATCH v2 2/9] net: tftp: Move tftp.h file from ./net to ./include/net
Simon Glass
sjg at chromium.org
Sat Jul 25 17:06:15 CEST 2015
[prune cc]
Hi Lukasz,
On 25 July 2015 at 09:02, Lukasz Majewski <l.majewski at majess.pl> wrote:
> On Sat, 25 Jul 2015 14:24:43 +0200
> Wolfgang Denk <wd at denx.de> wrote:
>
>> Dear Lukasz Majewski,
>>
>> In message <1437811877-13764-3-git-send-email-l.majewski at majess.pl>
>> you wrote:
>> > This change gives the ability to reuse the <tftp.h> header file by
>> > other subsystems (like e.g. dfu).
>> >
>> > Without this change compilation error emerges for the legacy
>> > update.c file.
>> >
>> > Signed-off-by: Lukasz Majewski <l.majewski at majess.pl>
>> >
>> > ---
>> > Changes for v2:
>> > - Move tftp.h from ./include to ./include/net/ directory
>> > ---
>> > include/net/tftp.h | 30 ++++++++++++++++++++++++++++++
>> > net/bootp.c | 2 +-
>> > net/net.c | 2 +-
>> > net/rarp.c | 2 +-
>> > net/tftp.c | 2 +-
>> > net/tftp.h | 30 ------------------------------
>> > 6 files changed, 34 insertions(+), 34 deletions(-)
>> > create mode 100644 include/net/tftp.h
>> > delete mode 100644 net/tftp.h
>>
>> NAK. Please resubmit and use "-M -C" when generating the patches, so
>> the renames will be properly detected and not result in a file
>> deletion and the addition of an (apparently new) file.
>
> Ok, Thanks for pointing this out.
Or use patman, which does this for you :-)
Regards,
Simon
More information about the U-Boot
mailing list