[U-Boot] [PATCH] mx6sxsabresd: Use 'int' for return values

Stefano Babic sbabic at denx.de
Sun Jul 26 12:13:29 CEST 2015


Hi Fabio,

On 22/07/2015 01:37, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
> 
> The variable 'ret' is used to store the value returned by pfuze_mode_init(),
> so it should be of type 'int' instead of 'unsigned int' in order to
> correctly handle negative numbers.
> 
> Fix the variable type.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>  board/freescale/mx6sxsabresd/mx6sxsabresd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx6sxsabresd/mx6sxsabresd.c b/board/freescale/mx6sxsabresd/mx6sxsabresd.c
> index 2ff960e..d58a79a 100644
> --- a/board/freescale/mx6sxsabresd/mx6sxsabresd.c
> +++ b/board/freescale/mx6sxsabresd/mx6sxsabresd.c
> @@ -199,7 +199,8 @@ static struct i2c_pads_info i2c_pad_info1 = {
>  int power_init_board(void)
>  {
>  	struct pmic *p;
> -	unsigned int reg, ret;
> +	unsigned int reg;
> +	int ret;
>  
>  	p = pfuze_common_init(I2C_PMIC);
>  	if (!p)
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list