[U-Boot] [PATCH 16/16] of: clean up OF_CONTROL ifdef conditionals

Marek Vasut marex at denx.de
Mon Jul 27 01:30:19 CEST 2015


On Sunday, July 26, 2015 at 08:38:46 PM, Pavel Machek wrote:
> Hi!
> 
> > We have flipped CONFIG_SPL_DISABLE_OF_CONTROL.  We have cleansing
> > devices, $(SPL_) and CONFIG_IS_ENABLED(), so we are ready to clear
> > 
> > away the ugly logic in include/fdtdec.h:
> >  #ifdef CONFIG_OF_CONTROL
> >  # if defined(CONFIG_SPL_BUILD) && !defined(SPL_OF_CONTROL)
> >  #  define OF_CONTROL 0
> >  # else
> >  #  define OF_CONTROL 1
> >  # endif
> >  #else
> >  # define OF_CONTROL 0
> >  #endif
> > 
> > Now CONFIG_IS_ENABLED(OF_CONTROL) is the substitute.  It refers to
> > CONFIG_OF_CONTROL for U-boot proper and CONFIG_SPL_OF_CONTROL for
> > SPL.
> 
> CONFIG_IS_ENABLED() is a bit too verbose. Could we get something
> shorter, like ENABLED()?
> 									Pavel

Linux has an IS_ENABLED() macro to my knowledge.

Best regards,
Marek Vasut


More information about the U-Boot mailing list