[U-Boot] [PATCH 10/55] exynos: i2c: Tidy up the driver model code
Simon Glass
sjg at chromium.org
Tue Jul 28 01:28:55 CEST 2015
On 5 July 2015 at 23:40, Heiko Schocher <hs at denx.de> wrote:
> Hello Simon,
>
> Am 03.07.2015 um 02:15 schrieb Simon Glass:
>>
>> The existing driver model implementation uses the old non-driver-model
>> code
>> to operate, but has become impossibly tangled as a result. The actual
>> algorithm is quite simple.
>>
>> Also the normal-speed and high-speed buses are quite different and it
>> doesn't seem that useful to put them in the same driver.
>>
>> Finally, there is a bug which breaks communication with the Maxim sound
>> codec and may cause problems with other device.
>>
>> Rewrite the driver model code for normal-speed operation so that it is
>> easier to understand, and fix the bug. Add a TODO to split the drivers.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> drivers/i2c/s3c24x0_i2c.c | 139
>> ++++++++++++++++++++++++++++++++++------------
>> 1 file changed, 103 insertions(+), 36 deletions(-)
>
>
> Reviewed-by: Heiko Schocher <hs at denx.de>
Applied to u-boot-dm.
More information about the U-Boot
mailing list