[U-Boot] [PATCH v2 16/16] apalis/colibri_t30: fix usb dm regression

Marcel Ziswiler marcel at ziswiler.com
Tue Jul 28 03:44:33 CEST 2015



On 27 July 2015 21:48:40 CEST, Stephen Warren <swarren at wwwdotorg.org> wrote:
>On 07/20/2015 04:35 PM, Marcel Ziswiler wrote:
>> From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
>>
>> Unfortunately currently both Apalis T30 as well as Colibri T30 crash
>> upon starting USB host support. This is due to the following patch
>not
>> having taken into account that our T30 device trees were defaulting
>to
>> peripheral only mode instead of otg:
>>
>> commit ddb9a502d18008e845d5a8fa03ec48630fa77fb7
>> dm: usb: tegra: Move most of init/uninit into a function
>
>> diff --git a/arch/arm/dts/tegra30-colibri.dts
>b/arch/arm/dts/tegra30-colibri.dts
>
>>   	/* EHCI instance 0: USB1_DP/N -> USBC_P/N */
>>   	usb at 7d000000 {
>>   		status = "okay";
>> -		dr_mode = "peripheral";
>> +		dr_mode = "otg";
>>   	};
>
>Is there SW control over driving VBUS for this port? If not, I don't 
>think switching to otg is correct/possible.

Yes, on Apalis T30 it is software controlled while on Colibri T30 it is hardware controlled (e.g. resp. cable decides). So this actually does work.

>It seems better to fix the crash in the code?

I kind of agree but this is outside the scope of this patch which just changes this to what everybody else does which actually works.


More information about the U-Boot mailing list