[U-Boot] [PATCH 1/4] gpio: UniPhier: add driver for UniPhier GPIO controller

[Masahiro Yamada]

The previous message was accidentally sent before I finish writing...




> If there is a reason why you need different size registers in your
> GPIO driver then I think it's fine to implement it that way. But in
> general we should use structures IMO.


This hardware has only two registers in each bank.  (DIR and DATA)

struct uniphier_gpio_bank {
    u32 data;
    u32 dir;
};

I could do this, but there is no good reason to do in this driver case.

The I/O access in this driver is already simple enough, i think.



-- 
Best Regards
Masahiro Yamada