[U-Boot] [PATCH 1/2] ARM: tegra: Add e2220-1170 board

[Simon Glass]

Hi Tom.

On 29 July 2015 at 20:42, Tom Warren <TWarren at nvidia.com> wrote:
> Simon,
>
> I can respond to your Kconfig questions below.
>
>> -----Original Message-----
>> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
>> Sent: Wednesday, July 29, 2015 4:02 PM
>> To: Stephen Warren
>> Cc: U-Boot Mailing List; Tom Warren; Stephen Warren; Thierry Reding
>> Subject: Re: [PATCH 1/2] ARM: tegra: Add e2220-1170 board
>>
>> Hi Stephen,
>>
>> On 29 July 2015 at 13:48, Stephen Warren <swarren at wwwdotorg.org> wrote:
>> >
>>
>> Commit message?
>>
>> > From: Stephen Warren <swarren at nvidia.com>
>> >
>> > Signed-off-by: Stephen Warren <swarren at nvidia.com>
>> > ---
>> >  arch/arm/dts/Makefile                              |   1 +
>> >  arch/arm/dts/tegra210-e2220-1170.dts               |  58 +++++
>> >  arch/arm/mach-tegra/tegra210/Kconfig               |   6 +
>> >  board/nvidia/e2220-1170/Kconfig                    |  12 +
>> >  board/nvidia/e2220-1170/MAINTAINERS                |   6 +
>> >  board/nvidia/e2220-1170/Makefile                   |   8 +
>> >  board/nvidia/e2220-1170/e2220-1170.c               |  48 ++++
>> >  board/nvidia/e2220-1170/pinmux-config-e2220-1170.h | 269
>> +++++++++++++++++++++
>> >  configs/e2220-1170_defconfig                       |  16 ++
>> >  include/configs/e2220-1170.h                       |  72 ++++++
>> >  10 files changed, 496 insertions(+)
>> >  create mode 100644 arch/arm/dts/tegra210-e2220-1170.dts
>> >  create mode 100644 board/nvidia/e2220-1170/Kconfig  create mode
>> > 100644 board/nvidia/e2220-1170/MAINTAINERS
>> >  create mode 100644 board/nvidia/e2220-1170/Makefile  create mode
>> > 100644 board/nvidia/e2220-1170/e2220-1170.c
>> >  create mode 100644 board/nvidia/e2220-1170/pinmux-config-e2220-1170.h
>> >  create mode 100644 configs/e2220-1170_defconfig  create mode 100644
>> > include/configs/e2220-1170.h
>> >
[snip]

>> > +
>> > +/* I2C */
>> > +#define CONFIG_SYS_I2C_TEGRA
>> > +#define CONFIG_CMD_I2C
>> > +
>> > +/* SD/MMC */
>> > +#define CONFIG_MMC
>> > +#define CONFIG_GENERIC_MMC
>> > +#define CONFIG_TEGRA_MMC
>> > +#define CONFIG_CMD_MMC
>> > +
>> > +/* Environment in eMMC, at the end of 2nd "boot sector" */ #define
>> > +CONFIG_ENV_IS_IN_MMC
>> > +#define CONFIG_SYS_MMC_ENV_DEV         0
>> > +#define CONFIG_SYS_MMC_ENV_PART                2
>> > +#define CONFIG_ENV_OFFSET              (-CONFIG_ENV_SIZE)
>> > +
>> > +/* SPI */
>> > +#define CONFIG_TEGRA114_SPI            /* Compatible w/ Tegra114 SPI */
>>
>> I think this is in Kconfig now.
> True. I'll send a patch that fixes this for all T114/T124 builds, plus P2571.

OK. BTW I think it's fine to do these sorts of clean-ups in separate
patches to be applied later, particular as you have other boards that
need adjusting.

>
>>
>> > +#define CONFIG_TEGRA114_SPI_CTRLS      6
>>
>> And this probably should be. What does it mean? I don't see it used anywhere.
> Unused, removed in same patch as above.
>
>>
>> > +#define CONFIG_SPI_FLASH_WINBOND
>> > +#define CONFIG_SF_DEFAULT_MODE         SPI_MODE_0
>> > +#define CONFIG_SF_DEFAULT_SPEED                24000000
>> > +#define CONFIG_CMD_SPI
>> > +#define CONFIG_CMD_SF
>> > +#define CONFIG_SPI_FLASH_SIZE          (4 << 20)
>> > +
>> > +/* USB2.0 Host support */
>> > +#define CONFIG_USB_EHCI
>> > +#define CONFIG_USB_EHCI_TEGRA
>>
>> Kconfig I think.
> Sorry, don't see this in any Kconfig file.

CONFIG_USB_EHCI is there, but USB_EHCI_TEGRA - it would be good if you
could convert it!

[snip]

Regards,
Simon