[U-Boot] Including both EHCI and xHCI does not compile

[Marek Vasut]

On Friday, July 31, 2015 at 07:02:20 AM, Bin Meng wrote:
> Hi Marek,

Hello Bin,

> With both CONFIG_USB_EHCI and CONFIG_USB_XHCI included, it does not build.
> 
> drivers/usb/host/xhci.o: In function `submit_control_msg':
> /git/u-boot/drivers/usb/host/xhci.c:1030: multiple definition of
> `submit_control_msg'
> drivers/usb/host/ehci-hcd.o:/git/u-boot/drivers/usb/host/ehci-hcd.c:1552:
> first defined here
> drivers/usb/host/xhci.o: In function `submit_bulk_msg':
> /git/u-boot/drivers/usb/host/xhci.c:1043: multiple definition of
> `submit_bulk_msg'
> drivers/usb/host/ehci-hcd.o:/git/u-boot/drivers/usb/host/ehci-hcd.c:1546:
> first defined here
> drivers/usb/host/xhci.o: In function `submit_int_msg':
> /git/u-boot/drivers/usb/host/xhci.c:1051: multiple definition of
> `submit_int_msg'
> drivers/usb/host/ehci-hcd.o:/git/u-boot/drivers/usb/host/ehci-hcd.c:1558:
> first defined here
> drivers/usb/host/xhci.o: In function `usb_lowlevel_init':
> /git/u-boot/drivers/usb/host/xhci.c:1061: multiple definition of
> `usb_lowlevel_init'
> drivers/usb/host/ehci-hcd.o:/git/u-boot/drivers/usb/host/ehci-hcd.c:1132:
> first defined here
> drivers/usb/host/xhci.o: In function `usb_lowlevel_stop':
> /git/u-boot/drivers/usb/host/xhci.c:1093: multiple definition of
> `usb_lowlevel_stop'
> drivers/usb/host/ehci-hcd.o:/git/u-boot/drivers/usb/host/ehci-hcd.c:1126:
> first defined here
> 
> Can we get this fixed? Thanks!

This has always been the case indeed. We can get this fixed, patches are
welcome. I believe that moving forward with DM should help getting this
resolved.

Best regards,
Marek Vasut