[U-Boot] [PATCH v3 2/2] Clean all defconfigs with savedefconfig

Ian Campbell ijc at hellion.org.uk
Mon Jun 1 11:46:52 CEST 2015


On Mon, 2015-06-01 at 15:45 +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> On Wed, May 13, 2015 at 6:12 AM, Tom Rini <trini at konsulko.com> wrote:
> > On Tue, May 12, 2015 at 02:46:24PM -0500, Joe Hershberger wrote:
> >
> >> In order to reduce merge conflicts and to maintain the simplest possible
> >> defconfig files, we should be using the savedefconfig feature of Kconfig
> >> every time a new feature is added. This keeps the defconfig settings to
> >> a minimum (only those things not default) and keeps them in the same
> >> order as the Kconfig options.
> >>
> >> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> >> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> >> Acked-by: Stephen Warren <swarren at wwwdotorg.org>
> >> Cc: Tom Rini <trini at konsulko.com>
> >>
> >
> > Applied to u-boot/master, thanks!
> 
> This patch wiped out all comments we had in sunxi defconfigs.
> The comments include description for the boards, a link to a
> wiki page, explanations for regulator and gpio settings.
> 
> Hans, Ian, should we move that info to some other place that's
> safer?

The information is certainly useful and should be preserved. If we can't
arrange for savedefconfig to preserve useful information (my preference)
we should indeed put it somewhere else, but where? MAINTAINERS files
perhaps?

Tom -- perhaps in the meantime we could get a partial revert?

Ian.



More information about the U-Boot mailing list