[U-Boot] [PATCH v3 2/2] Clean all defconfigs with savedefconfig

[Tom Rini]

On Mon, Jun 01, 2015 at 08:41:34AM -0500, Joe Hershberger wrote:
> Hi Ian,
> 
> On Mon, Jun 1, 2015 at 4:46 AM, Ian Campbell <ijc at hellion.org.uk> wrote:
> > On Mon, 2015-06-01 at 15:45 +0800, Chen-Yu Tsai wrote:
> >> Hi,
> >>
> >> On Wed, May 13, 2015 at 6:12 AM, Tom Rini <trini at konsulko.com> wrote:
> >> > On Tue, May 12, 2015 at 02:46:24PM -0500, Joe Hershberger wrote:
> >> >
> >> >> In order to reduce merge conflicts and to maintain the simplest possible
> >> >> defconfig files, we should be using the savedefconfig feature of Kconfig
> >> >> every time a new feature is added. This keeps the defconfig settings to
> >> >> a minimum (only those things not default) and keeps them in the same
> >> >> order as the Kconfig options.
> >> >>
> >> >> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> >> >> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> >> >> Acked-by: Stephen Warren <swarren at wwwdotorg.org>
> >> >> Cc: Tom Rini <trini at konsulko.com>
> >> >>
> >> >
> >> > Applied to u-boot/master, thanks!
> >>
> >> This patch wiped out all comments we had in sunxi defconfigs.
> >> The comments include description for the boards, a link to a
> >> wiki page, explanations for regulator and gpio settings.
> >>
> >> Hans, Ian, should we move that info to some other place that's
> >> safer?
> >
> > The information is certainly useful and should be preserved. If we can't
> > arrange for savedefconfig to preserve useful information (my preference)
> > we should indeed put it somewhere else, but where? MAINTAINERS files
> > perhaps?
> 
> I don't think savedefconfig can do this as is. Someone would have to
> work with the Linux kernel build guys to add a feature like that, I
> think.
> 
> > Tom -- perhaps in the meantime we could get a partial revert?
> 
> This will just happen again any time someone moves any config. You're
> much better off just moving it to the MAINTAINERS file now if it's
> valuable information. That or into a README in doc like other stuff
> does.

This information belongs in a README somewhere.  Just like you can't
keep notes in the Linux kernel's arch/*/configs/ files you can't keep
notes in the top-level configs directory in U-Boot (just like you can't
keep notes in the defconfig files in other Kbuild projects, unless
they're being extra careful about only hand-editing those files).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150601/f3969ff9/attachment.sig>