[U-Boot] [PATCH] ARM: phytec: pcm051: drop unused CONFIG_NET_MULTI

Joe Hershberger joe.hershberger at gmail.com
Mon Jun 1 20:34:12 CEST 2015


Hi Lars,

On Mon, Jun 1, 2015 at 9:59 AM,  <poeschel at lemonage.de> wrote:
> From: Lars Poeschel <poeschel at lemonage.de>
>
> Drop unused CONFIG_NET_MULTI.
> Also drop CONFIG_USE_IRQ, that is not used either.
>
> Signed-off-by: Lars Poeschel <poeschel at lemonage.de>
> ---
>  include/configs/pcm051.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/configs/pcm051.h b/include/configs/pcm051.h
> index c0bb227..eef3269 100644
> --- a/include/configs/pcm051.h
> +++ b/include/configs/pcm051.h
> @@ -163,10 +163,8 @@
>  #define CONFIG_USB_ETH_RNDIS
>  #endif /* CONFIG_MUSB_GADGET */
>
> -/* Unsupported features */
> -#undef CONFIG_USE_IRQ

These are unrelated changes. They should be two separate patches.

Also, you say this is unused, but you are editing an ARM board and it
seems that the arch/arm/lib/ source does refer to this. Are you sure
it is unused? If so, Please make a separate patch with more
explanation instead of adding it into another patch as a me-too.

> -#define CONFIG_NET_MULTI

Since this is not used anywhere, can you remove it from all of the
configs that still define it all in the same patch?

> +/* Network. */
>  #define CONFIG_PHY_GIGE
>  #define CONFIG_PHYLIB
>  #define CONFIG_PHY_SMSC

Thanks,
-Joe


More information about the U-Boot mailing list