[U-Boot] [PATCH] sunxi: Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default

Joe Hershberger joe.hershberger at gmail.com
Thu Jun 4 00:21:44 CEST 2015


Hi Tom,

On Wed, Jun 3, 2015 at 5:12 PM, Tom Rini <trini at konsulko.com> wrote:
> On Wed, Jun 03, 2015 at 08:12:16PM +0200, Hans de Goede wrote:
>
>> Select CONFIG_CMD_NET and CONFIG_CMD_SETEXPR by default rather then
>> needing to have this in every sunxi defconfig file.
>>
>> This also fixes the Merrii_A80_Optimus defconfig no longer building.
>>
>> Cc: Maxin B. John <maxin.john at enea.com>
>> Reported-by: Maxin B. John <maxin.john at enea.com>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> Joe? Masahiro?  It feels like something has gone wrong with the
> conversion here.  Or do people need to get used to the defconfig files
> being a non-trivial size?  Or do we need some more default y if ...
> lines around things?  Or a few of the above?  Thanks!

It seems we should select good defaults. Maybe we should try to agree
which way we should err. Make u-boot bigger by default, and boards
that are limited can disable features? Or should we enable commands on
boards that "need" a feature and keep u-boot slim by default?

I don't like the half measure of defining a different default for one
platform than another unless it is actually something inherent in the
platform, and in that case it should be enabled by a "selects" under
the platform Kconfig.

I agree we want to have smaller defconfigs rather than bigger, but
there are lots of features and many boards will not agree, so the
defconfigs of many boards will have to contain something.

-Joe


More information about the U-Boot mailing list