[U-Boot] image-fit: Fix compiler warning in fit_conf_print()

[Hans de Goede]

Hi All,

On 29-05-15 15:09, Hans de Goede wrote:
> This fixes the following compiler warning:
>
> In file included from tools/common/image-fit.c:1:0:
> ./tools/../common/image-fit.c: In function ‘fit_conf_print’:
> ./tools/../common/image-fit.c:1470:27: warning: logical not is only applied
>   to the left hand side of comparison [-Wlogical-not-parentheses]
>      (const char **)&uname) > 0;

ping? it would be nice to get this fixed, as it is the only compiler warning
I see when building u-boot.

Tom, can you pick this one up directly perhaps?

Regards,

Hans


>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>   common/image-fit.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/image-fit.c b/common/image-fit.c
> index 4bd8fea..28f7aa8 100644
> --- a/common/image-fit.c
> +++ b/common/image-fit.c
> @@ -1464,10 +1464,10 @@ void fit_conf_print(const void *fit, int noffset, const char *p)
>
>   	/* Print out all of the specified loadables */
>   	for (loadables_index = 0;
> -	     !fdt_get_string_index(fit, noffset,
> +	     fdt_get_string_index(fit, noffset,
>   			FIT_LOADABLE_PROP,
>   			loadables_index,
> -			(const char **)&uname) > 0;
> +			(const char **)&uname) == 0;
>   	     loadables_index++)
>   	{
>   		if (loadables_index == 0) {
>