[U-Boot] [U-Boot, v4, 1/4] Kconfig: Enable usage of escape char '\' in string values

Tom Rini trini at konsulko.com
Mon Jun 8 23:53:23 CEST 2015


On Fri, May 29, 2015 at 11:47:32AM +0200, Stefan Roese wrote:

> I might have missed something, but I failed to use the escape char '\'
> in strings. To pass a printf format string like "foo %d bar\n" via
> Kconfig to the code.
> 
> Right now its not possible to use the escape character '\' in Kconfig
> string values correctly to e.g. set this string value "test output\n".
> The '\n' will be converted to 'n'.
> 
> The current implementation removes some of the '\' chars from the input
> string in conf_set_sym_val(). Examples:
> 
> '\'	-> ''
> '\\'	-> '\'
> '\\\'	-> '\'
> '\\\\'	-> '\\'
> ...
> 
> And then doubles the backslash chars in the output string in
> sym_escape_string_value(). Example:
> 
> '\'	-> ''	-> ''
> '\\'	-> '\'	-> '\\'
> '\\\'	-> '\'	-> '\\'
> '\\\\'	-> '\\'	-> '\\\\'
> ...
> 
> As you see in these examples, its impossible to generate a single '\'
> charater in the output string as its needed for something like '\n'.
> 
> This patch now changes this behavior to not drop some backslashes in
> conf_set_sym_val() and to not add new backslashes in the resulting
> output string. Removing the function sym_escape_string_value()
> completely as its not needed anymore.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150608/3e5da4b5/attachment.sig>


More information about the U-Boot mailing list