[U-Boot] [PATCH] Nokia RX-51: Fix calculating return address in save_boot_params

Simon Glass sjg at chromium.org
Thu Jun 11 02:50:59 CEST 2015


Hi Pali,

On 9 June 2015 at 12:27, Pali Rohár <pali.rohar at gmail.com> wrote:
>
> On Tuesday 09 June 2015 20:11:22 Simon Glass wrote:
> > On 9 June 2015 at 10:05, Pali Rohár <pali.rohar at gmail.com> wrote:
> > > Commit e11c6c279d823dc0d2f470c5c2e3c0a9854a640f broke calculating
> > > lr register in function save_boot_params() and caused U-Boot to
> > > crash at early boot time on Nokia N900 board.
> > >
> > > This patch fix calculating return address in lr register and make
> > > Nokia N900 board bootable again. Patch was tested in qemu and also
> > > on real N900 HW.
> > >
> > > Signed-off-by: Pali Rohár <pali.rohar at gmail.com>
> > > ---
> > >
> > >  board/nokia/rx51/lowlevel_init.S |    4 ----
> > >  1 file changed, 4 deletions(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Tom, can you please apply this patch for 2015.07?
>
> Simon & others: in future, please can you CC me all patches which touch
> Nokia N900 board code? We can prevent such breakage. Also you can test
> u-boot for n900 in qemu.

Here's the list patman generates for that patch:

      Cc:  Rob Herring <robh at kernel.org>
      Cc:  Simon Glass <sjg at chromium.org>
      Cc:  Tom Warren <twarren at nvidia.com>
      Cc:  Thierry Reding <treding at nvidia.com>
      Cc:  Siarhei Siamashka <siarhei.siamashka at gmail.com>
      Cc:  Bryan Brinsko <bryan.brinsko at rockwellcollins.com>
      Cc:  Ian Campbell <ijc at hellion.org.uk>
      Cc:  York Sun <yorksun at freescale.com>
      Cc:  Nishanth Menon <nm at ti.com>
      Cc:  Hans de Goede <hdegoede at redhat.com>
      Cc:  u-boot at lists.denx.de
      Cc:  Tom Rini <trini at konsulko.com>
      Cc:  Albert Aribaud <albert.u.boot at aribaud.net>
      Cc:  Peng Fan <Peng.Fan at freescale.com>
      Cc:  Georges Savoundararadj <savoundg at gmail.com>
      Cc:  Minkyu Kang <mk7.kang at samsung.com>
      Cc:  "Pali Rohár" <pali.rohar at gmail.com>

I was probably just unwilling to email so many people, but in future I
will be more willing.

>
>
> --
> Pali Rohár
> pali.rohar at gmail.com

Regards,
Simon


More information about the U-Boot mailing list