[U-Boot] [PATCH 1/2] sunxi: musb: Do not fully reset the controler from sunxi_musb_disable

Ian Campbell ijc at hellion.org.uk
Sun Jun 14 13:46:44 CEST 2015


On Sun, 2015-06-14 at 12:40 +0200, Hans de Goede wrote:
> Fully resetting the controller is a too big hammer, and the musb_core will
> then afterwards fail to communicate with any endpoints other then 0 as
> too much state was cleared.
> 
> Instead report vbus low for 200ms which will effectively end the current
> session without needing to do a full reset.
> 
> This fixes usb mass-storage devices no longer working after a "usb reset"
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Acked-by: Ian Campbell <ijc at hellion.org.uk>

One question (which turned into two) (both more for the musb maint than
you):

> +/* musb_core does not call enable / disable in a balanced manner <sigh> */
> +static bool enabled = false;

Is this sufficient, or should we be reference counting? Or should the
core be fixed?

Ian.



More information about the U-Boot mailing list