[U-Boot] [PATCH] imx: imximage: add new CHECK/CLR BIT command

[Otavio Salvador]

On Mon, Jun 15, 2015 at 12:17 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Sun, Jun 14, 2015 at 6:38 AM, Peng Fan <Peng.Fan at freescale.com> wrote:
>> Since rom code supports the following commands, add new commands support in
>> imximage.
>>
>> 1. CHECK_BITS_SET 4 [address] [mask bit]
>>    means:
>>    while ((*address & mask) != mask);
>>
>> 2. CHECK_BITS_CLR 4 [address] [mask bit]
>>    means:
>>    while ((*address & ~mask) != 0);
>>
>> 2. CLR_BIT 4 [address] [mask bit]
>>    means:
>>    *address = *address & ~mask;
>>
>> dcd_v2_t is redefined, because there may not be only one write data command,
>> there may be many different commands like CHECK_BITS_SET, CHECK_BITS_CLR and
>> CLR_BIT.
>>
>> dcd_len is still leaved there, since changing it needs changes for dcd v1.
>> For v2, we check whether dcd size is larger than MAX_DCD_SIZE_V2, but not
>> dcd_len.
>>
>> Signed-off-by: Peng Fan <Peng.Fan at freescale.com>
>
> What about just using SPL mechanism instead?

While I agree we ought to use SPL as much as possible I also believe
the DCD support should be as complete as possible; some people might
have reasons to avoid the SPL and rely on DCD for it.

Do you believe SPL can be assumed to be a viable option for everyone?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750