[U-Boot] [PATCH 1/4] spl, common, serial: build SPL without serial support

[Tom Rini]

On Mon, Jun 15, 2015 at 02:20:59PM +0200, Heiko Schocher wrote:

> This patch enables building SPL without
> CONFIG_SPL_SERIAL_SUPPORT support.
> 
> Signed-off-by: Heiko Schocher <hs at denx.de>

I like that we're starting down this path.  But can you explain why we
need each of these changes:

>  arch/arm/lib/interrupts.c          | 4 ++--
>  arch/arm/mach-at91/arm926ejs/cpu.c | 2 +-
>  common/cli_readline.c              | 2 +-
>  common/cli_simple.c                | 2 +-
>  lib/display_options.c              | 4 ++--

Having gone down the path of disabling output in SPL before due to size
constraints I didn't need to modify those files (but it was on an older
version)

>  common/image.c                     | 8 ++++++--

In this case I just said we only need those functions (and their
strings!) when we have SPL_SERIAL available.  It may be worth
re-checking what parts of this file we really need available in SPL
even.

>  common/spl/spl.c                   | 9 +++++++++

We should be able to be fine without a preloader_console_init() func I
think.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150615/f355e9fd/attachment.sig>