[U-Boot] [PATCH] imx: imximage: add new CHECK/CLR BIT command

[Stefano Babic]

Hi Peng,

On 15/06/2015 17:17, Fabio Estevam wrote:
> Hi Peng,
> 
> On Sun, Jun 14, 2015 at 6:38 AM, Peng Fan <Peng.Fan at freescale.com> wrote:
>> Since rom code supports the following commands, add new commands support in
>> imximage.
>>
>> 1. CHECK_BITS_SET 4 [address] [mask bit]
>>    means:
>>    while ((*address & mask) != mask);
>>
>> 2. CHECK_BITS_CLR 4 [address] [mask bit]
>>    means:
>>    while ((*address & ~mask) != 0);
>>
>> 2. CLR_BIT 4 [address] [mask bit]
>>    means:
>>    *address = *address & ~mask;
>>
>> dcd_v2_t is redefined, because there may not be only one write data command,
>> there may be many different commands like CHECK_BITS_SET, CHECK_BITS_CLR and
>> CLR_BIT.
>>
>> dcd_len is still leaved there, since changing it needs changes for dcd v1.
>> For v2, we check whether dcd size is larger than MAX_DCD_SIZE_V2, but not
>> dcd_len.
>>
>> Signed-off-by: Peng Fan <Peng.Fan at freescale.com>
> 
> What about just using SPL mechanism instead?


Thanks, Fabio. I can only join to your proposal.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================