[U-Boot] [PATCH 1/4] ARM: Tegra210: Add SoC code/include files for T210

[Stephen Warren]

On 06/03/2015 02:35 PM, Tom Warren wrote:
> All based off of Tegra124. As a Tegra210 board is brought
> up, these may change a bit to match the HW more closely,
> but probably 90% of this is identical to T124.

Rather than duplicating lots of headers and code, can we share the 
content with other chips?

> diff --git a/arch/arm/include/asm/arch-tegra210/funcmux.h b/arch/arm/include/asm/arch-tegra210/funcmux.h

We should be able to drop funcmux support completely now that we're 
programming entire board pinmux tables.

> diff --git a/arch/arm/include/asm/arch-tegra210/gpio.h b/arch/arm/include/asm/arch-tegra210/gpio.h

> +enum gpio_pin {
> +	GPIO_PA0 = 0,	/* pin 0 */
> +	GPIO_PA1,

Given the move to DT, are any of these GPIO_xxx values actually used? I 
wonder how many other types/defines in the other files are actually 
used, rather than simply left over from times gone by.

> diff --git a/arch/arm/include/asm/arch-tegra210/hardware.h b/arch/arm/include/asm/arch-tegra210/hardware.h

Can we drop this file? I don't see a hardware.h in any of the other 
arch-tegra*/ directories.

> diff --git a/arch/arm/include/asm/arch-tegra210/tegra.h b/arch/arm/include/asm/arch-tegra210/tegra.h

> +#define BCT_ODMDATA_OFFSET	1704	/* offset to ODMDATA word */
> +
> +#undef NVBOOTINFOTABLE_BCTSIZE
> +#undef NVBOOTINFOTABLE_BCTPTR
> +#define NVBOOTINFOTABLE_BCTSIZE	0x48	/* BCT size in BIT in IRAM */
> +#define NVBOOTINFOTABLE_BCTPTR	0x4C	/* BCT pointer in BIT in IRAM */

Have you validated those? I'm pretty sure the BCT and perhaps BIT layout 
changed in T210, and those values match T124.

Have all the clock tables and IDs been updated to match T210? If not, I 
think we should do that before checking in the code, or it'll be misleading.