[U-Boot] [PATCH 1/4] ARM: Tegra210: Add SoC code/include files for T210

[Stephen Warren]

On 06/15/2015 02:04 PM, Tom Warren wrote:
>
>
>> -----Original Message-----
>> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
>> Sent: Monday, June 15, 2015 10:11 AM
>> To: Tom Warren
>> Cc: u-boot at lists.denx.de; Stephen Warren; Tom Warren
>> Subject: Re: [U-Boot] [PATCH 1/4] ARM: Tegra210: Add SoC code/include files
>> for T210
>>
>> On 06/03/2015 02:35 PM, Tom Warren wrote:
>>> All based off of Tegra124. As a Tegra210 board is brought up, these
>>> may change a bit to match the HW more closely, but probably 90% of
>>> this is identical to T124.
>>
>> Rather than duplicating lots of headers and code, can we share the content
>> with other chips?
 >
> Sure, but I wasn't looking at this patchset as a reworking of all Tegra common headers, but an inclusion of T210 support. We can then move to common/shared content after this is in, or someone (you?) can do it now before I add T210 support, but that'll delay it.

The problem here is that the same excuse against cleanup is made every 
time a new SoC comes along, and the cleanup never happens.

>>> diff --git a/arch/arm/include/asm/arch-tegra210/funcmux.h
>>> b/arch/arm/include/asm/arch-tegra210/funcmux.h
>>
>> We should be able to drop funcmux support completely now that we're
>> programming entire board pinmux tables.
 >
> I'll look into it, but I believe funcmux is only used to get early UART muxes set, which is done before the pinmux table is parsed/written.

There's no guarantee funcmux will work in general for the UARTs. The 
best solution would be to apply the pinmux table before doing anything. 
That way, we wouldn't need anything custom to try and get the UART working.