[U-Boot] [PATCH 08/10] x86: Add MultiProcessor (MP) table APIs

[Bin Meng]

Hi Simon,

On Wed, Jun 17, 2015 at 9:15 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 17 June 2015 at 01:42, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Simon,
>>
>> On Tue, Jun 16, 2015 at 10:46 AM, Simon Glass <sjg at chromium.org> wrote:
>>> Hi Bin,
>>>
>>> On 15 June 2015 at 02:00, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>> The MP table provides a way for the operating system to support
>>>> for symmetric multiprocessing as well as symmetric I/O interrupt
>>>> handling with the local APIC and I/O APIC. We provide a bunch of
>>>> APIs for U-Boot to write the floating table, configuration table
>>>> header as well as base and extended table entries.
>>>>
>>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>>> ---
>>>>
>>>>  arch/x86/include/asm/mpspec.h | 434 ++++++++++++++++++++++++++++++++++++++++++
>>>>  arch/x86/lib/Makefile         |   1 +
>>>>  arch/x86/lib/mpspec.c         | 238 +++++++++++++++++++++++
>>>>  3 files changed, 673 insertions(+)
>>>>  create mode 100644 arch/x86/include/asm/mpspec.h
>>>>  create mode 100644 arch/x86/lib/mpspec.c
>>>
>>> Does this avoid needing SFI?
>>>
>>
>> Yes, SFI is not needed, although it can be turned on and built pass on
>> Crown Bay without any problem. I've tested SFI on Crown Bay and the
>> only issue is that interrupt is still routed to 8259 instead of I/O
>> APIC.
>
> That's great! I think the README.x86 should be updated to indicate
> this too (i.e. mention that multi-CPUs are handled by this new feature
> or SFI).
>

Sure, will update README.x86 in v2.

> [snip]
>
> Regards,
> Simon

Regards,
Bin