[U-Boot] corrupted tags in git://git.denx.de/u-boot ?

[Igor Grinberg]

Hi Wolfgang,

Thanks for the quick reply!

On 06/23/15 16:31, Wolfgang Denk wrote:
> Dear Igor,
> 
> In message <55894D63.508 at compulab.co.il> you wrote:
>>
>> While running git fsck --full, I've noticed the following:
>> -------------------------------cut-------------------------------------
>> $ git fsck --full
>> Checking object directories: 100% (256/256), done.
>> error in tag 9bf86baaa3b35b25baa2d664e2f7f6cafad689ee: unterminated header
>> error in tag c7071e6d645a8e13adb0d4cea2caad27213fa62f: unterminated header
>> error in tag eb394f56db3e05d00891d6dc36a00df0025cf255: unterminated header
>> Checking objects: 100% (356677/356677), done.
>> Checking connectivity: 356680, done.
>> -------------------------------cut-------------------------------------
> 
> Running this on the master repo gives:
> 
> -> git fsck --full
> Checking object directories: 100% (256/256), done.
> Checking objects: 100% (328644/328644), done.
> Checking connectivity: 325719, done.
> 
>> Is it only me suffering from some kind of corruption on remote update
>> or do we all have the same problem and I'm the first to notice (or just
>> missed a thread about this)?
> 
> Doing a fresh clone from the public repo gives this:
> 
> -> git clone git://git.denx.de/u-boot
> Cloning into 'u-boot'...
> remote: Counting objects: 325719, done.
> remote: Compressing objects: 100% (62600/62600), done.
> remote: Total 325719 (delta 260566), reused 322218 (delta 257187)
> Receiving objects: 100% (325719/325719), 73.56 MiB | 1.55 MiB/s, done.
> Resolving deltas: 100% (260566/260566), done.
> Checking connectivity... done.
> -> cd u-boot/
> /tmp/u-boot
> -> git fsck --full
> Checking object directories: 100% (256/256), done.
> Checking objects: 100% (325719/325719), done.
> Checking connectivity: 325719, done.
> 
> In other words, I cannot reproduce your issue here.

May be it has something to do with my git version?
$ git --version
git version 2.3.6

I performed the clone test too and it gets the same error:
$ git clone git://git.denx.de/u-boot test
Cloning into 'test'...
remote: Counting objects: 325719, done.
remote: Compressing objects: 100% (62600/62600), done.
remote: Total 325719 (delta 260566), reused 322218 (delta 257187)
Receiving objects: 100% (325719/325719), 73.56 MiB | 2.48 MiB/s, done.
Resolving deltas: 100% (260566/260566), done.
Checking connectivity... done.
$ cd test/
$ git fsck --full
Checking object directories: 100% (256/256), done.
error in tag eb394f56db3e05d00891d6dc36a00df0025cf255: unterminated header
error in tag 9bf86baaa3b35b25baa2d664e2f7f6cafad689ee: unterminated header
error in tag c7071e6d645a8e13adb0d4cea2caad27213fa62f: unterminated header
Checking objects: 100% (325719/325719), done.
Checking connectivity: 325719, done.

It seems that the check for termination with '\n' in tag headers
started to be a requirement from git version 2.2.0?
This [1] seems to be the patch that triggers the message I see.

[1] https://github.com/git/git/commit/4d0d89755e82c40df88cf94d84031978f8eac827

-- 
Regards,
Igor.