[U-Boot] [PATCH 01/22] usb: Always declare usb function prototypes

Simon Glass sjg at chromium.org
Mon Jun 29 05:44:46 CEST 2015


On 17 June 2015 at 13:33, Hans de Goede <hdegoede at redhat.com> wrote:
> There is no harm in declaring the function prototypes even if nothing
> implements them, and when CONFIG_DM_USB=y the various usb functions are
> available regardless of any controller drivers being enabled.
>
> This fixes compile warnings due to missing prototypes on ARCHs where
> the ARCH Kconfig always enables CONFIG_DM_USB and various usb drivers.
>
> One could argue that in the case of no controllers CONFIG_DM_USB should not
> be set, but this problem is typically seen during bringup of boards which
> do actually have usb controllers.
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
> Changes in v2:
> -Simply always define the function prototypes instead of adding yet another
>  condition to the already unwieldly #if def ... || def ... condition
> ---
>  include/usb.h | 15 ---------------
>  1 file changed, 15 deletions(-)

Acked-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list