[U-Boot] [PATCH] net: lpc32xx: correct command register reset value

[Albert ARIBAUD]

Bonjour Vladimir,

Le Sun, 28 Jun 2015 06:03:38 +0300, Vladimir Zapolskiy <vz at mleia.com> a
écrit :

> According to LPC32x0 User Manual the following bits in Command
> register 0x3106_0100 are defined:
> 
>   Bit    Symbol
>     2  - Unused
>     3  RegReset
>     4   TxReset
>     5   RxReset
> 
> Fix wrong (1-bit shifted right) COMMAND_RESETS value, which sets
> an unused bit, but neglects RxReset.
> 
> Signed-off-by: Vladimir Zapolskiy <vz at mleia.com>
> ---
>  drivers/net/lpc32xx_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c
> index 8dcbb4a..72451a9 100644
> --- a/drivers/net/lpc32xx_eth.c
> +++ b/drivers/net/lpc32xx_eth.c
> @@ -170,7 +170,7 @@ struct lpc32xx_eth_registers {
>  #define COMMAND_PASSRUNTFRAME 0x00000040
>  #define COMMAND_FULL_DUPLEX   0x00000400
>  /* Helper: general reset */
> -#define COMMAND_RESETS        0x0000001C
> +#define COMMAND_RESETS        0x00000038
>  
>  /* STATUS register bitfields/masks and offsets (see Table 283) */
>  #define STATUS_RXSTATUS 0x00000001

Acked-by: Albert ARIBAUD (3ADEV) <albert.aribaud at 3adev.fr>

Thanks for pointing this bug out!

Cordialement,
Albert ARIBAUD
3ADEV