[U-Boot] [PATCH 2/2] qe: use strncpy instead of strcpy

[York Sun]

On 05/05/2015 06:40 PM, Zhao Qiang-B45475 wrote:
> On Tue, May 5, 2015 at 5:41 PM, Michael Trimarchi wrote:
> 
>> -----Original Message-----
>> From: Michael Trimarchi [mailto:michael at amarulasolutions.com]
>> Sent: Tuesday, May 05, 2015 5:41 PM
>> To: Zhao Qiang-B45475
>> Cc: u-boot at lists.denx.de; Sun York-R58495
>> Subject: Re: [U-Boot] [PATCH 2/2] qe: use strncpy instead of strcpy
>>
>> Hi
>>
>> On Tue, May 5, 2015 at 5:15 PM, qiang.zhao at freescale.com
>> <qiang.zhao at freescale.com> wrote:
>>> On Tue, May 5, 2015 at 4:33 PM, Michael Trimarchi wrote:
>>>> -----Original Message-----
>>>> From: Michael Trimarchi [mailto:michael at amarulasolutions.com]
>>>> Sent: Tuesday, May 05, 2015 4:33 PM
>>>> To: Zhao Qiang-B45475
>>>> Cc: u-boot at lists.denx.de; Sun York-R58495
>>>> Subject: Re: [U-Boot] [PATCH 2/2] qe: use strncpy instead of strcpy
>>>>
>>>> Hi
>>>>
>>>> On Tue, May 5, 2015 at 3:53 PM, Zhao Qiang <B45475 at freescale.com>
>> wrote:
>>>>> strncpy is safer than strcpy, use it to instead of strcpy.
>>>>>
>>>>> Signed-off-by: Zhao Qiang <B45475 at freescale.com>
>>>>> ---
>>>>>  drivers/qe/qe.c | 2 +-
>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/qe/qe.c b/drivers/qe/qe.c index
>>>>> f1df0a4..08620b2
>>>>> 100644
>>>>> --- a/drivers/qe/qe.c
>>>>> +++ b/drivers/qe/qe.c
>>>>> @@ -435,7 +435,7 @@ int qe_upload_firmware(const struct qe_firmware
>>>> *firmware)
>>>>>          * saved microcode information and put in the new.
>>>>>          */
>>>>>         memset(&qe_firmware_info, 0, sizeof(qe_firmware_info));
>>>>> -       strcpy(qe_firmware_info.id, (char *)firmware->id);
>>>>> +       strncpy(qe_firmware_info.id, (char *)firmware->id, 62);
>>>>
>>>> is 62 somenthing that can be calculated?
>>>
>>> The fireware->id is defined 62 bytes in the struct.
>>>
>>
>> and you don't like sizeof
> 
> Thank you for your suggestion.
> If there are something else need to be modify,
> I will use sizeof instead.

Looks like the id is a null-terminated string. Do you face the same issue as
patch 1/2 in this set? Would it be better to change the type to char?

York