[U-Boot] [PATCH 04/22] usb: Pass device instead of portnr to usb_legacy_port_reset

Simon Glass sjg at chromium.org
Tue Jun 30 16:58:47 CEST 2015


Hi Hans,

On 30 June 2015 at 06:31, Hans de Goede <hdegoede at redhat.com> wrote:
> Hi,
>
>
> On 29-06-15 05:44, Simon Glass wrote:
>>
>> Hi Hans,
>>
>> On 17 June 2015 at 13:33, Hans de Goede <hdegoede at redhat.com> wrote:
>>>
>>> Pass the usb_device instead of the portnr to usb_legacy_port_reset and
>>> rename it to usb_hub_port_reset as there is nothing legacy about it.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>>> ---
>>>   common/usb.c | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>>
>> Legacy as in not driver model.
>
>
> Except that it gets used in both device-model and non device model
> builds of the usb-stack.

Yes, and the non-driver-model stuff can presumably be considered
'legacy' at this point?

Acked-by: Simon Glass <sjg at chromium.org>

>
> Regards,
>
> Hans
>
> p.s.
>
> Thanks for reviewing this largish series!

You're welcome. It's a lot easier than writing it :-)

Regards,
Simon


More information about the U-Boot mailing list