[U-Boot] [RFC PATCH 10/13] dm: net: Tidy up designware driver ready for driver model

Joe Hershberger joe.hershberger at gmail.com
Sun Mar 1 18:49:24 CET 2015


Hi Simon,

On Sun, Mar 1, 2015 at 10:33 AM, Simon Glass <sjg at chromium.org> wrote:
>
> Adjust the error handling to use errno.h instead of returning -1. Change
> leaf functions to pass in the arguments they require rather than struct
> eth_device. Apart from simplifying the code it makes is easier to reuse
> these functions for driver model, since mostly they actually only use
> struct dw_eth_priv (which we can keep).
>
> Create a stub for each Ethernet operation function. This will allow use to
> share code with the driver model versions.

Looks simple.  I hope most other Ethernet drivers will be so easy.

> Signed-off-by: Simon Glass <sjg at chromium.org>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list