[U-Boot] [RFC PATCH v4 06/23] net: Refactor in preparation for driver model

[Simon Glass]

Hi Joe,

On 24 February 2015 at 17:02, Joe Hershberger <joe.hershberger at ni.com> wrote:
> Move some things around and organize things so that the driver model
> implementation will fit in more easily.
>
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> ---
>
> Changes in v4:
> -Fix compile regression in !DM_ETH case
>
> Changes in v3:
> -Move the get_dev_by_* protos to also be !DM_ETH like the impl
>
> Changes in v2: None
>
>  include/net.h | 68 +++++++++++++++++++++++++++-------------------------
>  net/eth.c     | 77 +++++++++++++++++++++++++++++++----------------------------
>  2 files changed, 76 insertions(+), 69 deletions(-)
>

I think I mention this in a later response. But for this patch I see
the errors below:

08: net: Refactor in preparation for driver model
       arm:  +   snow seaboard
       x86:  +   coreboot-x86
+../net/eth.c: In function ‘eth_register’:
+../net/eth.c:208:3: error: implicit declaration of function
‘eth_current_changed’ [-Werror=implicit-function-declaration]
+   eth_current_changed();
+   ^
+../net/eth.c: At top level:
+../net/eth.c:471:13: error: conflicting types for
‘eth_current_changed’ [-Werror]
+ static void eth_current_changed(void)
+             ^
+../net/eth.c:471:13: error: static declaration of
‘eth_current_changed’ follows non-static declaration
+../net/eth.c:208:3: note: previous implicit declaration of
‘eth_current_changed’ was here
+cc1: all warnings being treated as errors
+make[2]: *** [net/eth.o] Error 1
+make[1]: *** [net] Error 2
+make: *** [sub-make] Error 2

[snip]

Regards,
Simon