[U-Boot] [PATCH] am33xx, spl, siemens: enable debug uart output again

[Heiko Schocher]

Hello Simon,

Am 24.02.2015 14:31, schrieb Simon Glass:
> Hi Heiko,
>
> On 23 February 2015 at 23:18, Heiko Schocher <hs at denx.de> wrote:
>> a6b541b090: TI ARMv7: Don't use GD before crt0.S has set it
>>
>> moves the init of the debug uart at the very end of SPL code.
>> Enable it for the siemens board earlier, as they print
>> ddr settings ... all debug output before board_init_r()
>> is here currently useless. Maybe we must rework this
>> globally?
>
> Assuming we are talking about U-Boot proper, the DDR init should
> happen in board_init_f(), specifically dram_init(). so I think this
> code should be updated.
>
> If it is SPL, then DDR init should happen in SPL's board_init_f().

It is in SPL...

sdram_init() is called from:

./arch/arm/cpu/armv7/am33xx/board.c from s_init() ...

> I sent a series a few weeks ago (available at u-boot-dm branch
> spl-working) related to this topic:
>
> http://patchwork.ozlabs.org/patch/438581/

Ah ... Hmm... so "./arch/arm/cpu/armv7/am33xx/board.c" needs
a rework, right?

Is a simple rename s_init() -> board_init_f() correct?

@Tom: Could you help here?

bye,
Heiko
>> Signed-off-by: Heiko Schocher <hs at denx.de>
>> ---
>>
>>   board/siemens/common/board.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/board/siemens/common/board.c b/board/siemens/common/board.c
>> index cc0ac6b..fb2de48 100644
>> --- a/board/siemens/common/board.c
>> +++ b/board/siemens/common/board.c
>> @@ -43,6 +43,11 @@ void set_mux_conf_regs(void)
>>          /* Initalize the board header */
>>          enable_i2c0_pin_mux();
>>          i2c_set_bus_num(0);
>> +
>> +       /* enable early the console */
>> +       gd->baudrate = CONFIG_BAUDRATE;
>> +       serial_init();
>> +       gd->have_console = 1;
>>          if (read_eeprom() < 0)
>>                  puts("Could not get board ID.\n");
>>
>> --
>> 2.1.0
>>
>
> Regards,
> Simon
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany