[U-Boot] [PATCH] arm64: Add Xilinx ZynqMP support

[Michal Simek]

On 03/02/2015 03:23 PM, Tom Rini wrote:
> On Mon, Mar 02, 2015 at 09:24:45AM +0100, Michal Simek wrote:
>> On 03/02/2015 08:32 AM, Michal Simek wrote:
>>> On 02/27/2015 06:13 PM, Tom Rini wrote:
>>>> On Tue, Feb 24, 2015 at 09:02:09AM +0100, Michal Simek wrote:
>>>>
>>>>> Add basic Xilinx ZynqMP arm64 support.
>>>>> Serial and SD is supported.
>>>>> It supports emulation platfrom ep108 and QEMU.
>>>>>
>>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>> [snip]
>>>>> +/* Miscellaneous configurable options */
>>>>> +#define CONFIG_SYS_LOAD_ADDR		0x8000000
>>>>> +
>>>>> +/* Initial environment variables */
>>>>> +#define CONFIG_EXTRA_ENV_SETTINGS \
>>>>> +	"ethaddr=00:0a:35:00:01:22\0" \
>>>>
>>>> No, you can't hard-code an ethaddr in.
>>>
>>> ah yeah.
>>>
>>>>
>>>>> +	"kernel_addr=0x200000\0" \
>>>>> +	"initrd_addr=0xa00000\0" \
>>>>> +	"initrd_size=0x2000000\0" \
>>>>
>>>> These are really close together.  And I imagine mirror the usual values
>>>> on 32bit platforms.  Maybe it's time to move them around a bit for more
>>>> space?
>>>
>>> Currently I haven't had any problem with these values but I just don't know
>>> what will happen in future.
> 
> Right.  That's partly why I moved as much of the TI ARMv7 parts to the
> Linux kernel defined limits a while back, people managed to bump into
> overruns doing valid things.  I'd really like to see things default to
> something closer to the defined limits to start with and avoid those
> kind of problems a few years down the line.  8MB is fine for now but I
> can see people running over that and going "why does my initrd boot
> fail".

We will use FIT image and all these values won't be needed but
they are need to be here.
I have removed unused initrd_X in v2 because it is completely unused.



>>>>> +	"fdt_addr=0x100000\0" \
>>>>> +	"fdt_high=0x10000000\0" \
>>>>
>>>> We also shouldn't have to play "stop relocating the DT" games on
>>>> aarch64, right?  Since all memory is visible and that's why we have to
>>>> do those games on aarch32.
>>>
>>> Will play with it to confirm it.
>>
>> I have tested it and there must be limit - without limit kernel is not booting.
>> I am using your booti command.
> 
> Oh that's right, there is, even on arm64.
> 
> This got me to open up Documentation/arm64/booting.txt again and yes,
> FDT must be at base+512MB.  And looking over
> include/configs/ti_armv7_common.h again that's best enforced with
> bootm_size so that we can still shuffle things to fit and not overlap
> but still meet requirements.

bootm_size could work for us too but not a problem to fix it in the next
patch.
Do you see any other problem with ZynqMP support?

I have some patches depends on this that's why I would like to get this
basic port accepted and then start to push other stuff.

Thanks,
Michal






-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150302/df58df42/attachment.sig>