[U-Boot] [PATCH] usb_storage : scan all interfaces to find a storage device

Franck Jullien franck.jullien at gmail.com
Wed Mar 4 07:34:39 CET 2015


2015-03-03 23:28 GMT+01:00 Marek Vasut <marex at denx.de>:
> On Tuesday, March 03, 2015 at 10:17:11 PM, franck.jullien at gmail.com wrote:
>> From: Franck Jullien <franck.jullien at gmail.com>
>>
>> Mass storage is not necessary present on interface 0. This
>> patch allow usb_stor_scan to look in every available interface.
>>
>> Signed-off-by: Franck Jullien <franck.jullien at gmail.com>
>
> Hi!
>
> Do you happen to have such a device which isn't present on interface 0?
>
> Also, can you please rework the patch such that level of indentation would
> be reasonably low? Possibly by factoring some code into a separate function?
> I see that the code already has some really nasty indent and your patch even
> adds to that.
>
> Thank you!
>
> Best regards,
> Marek Vasut

I do have such a device. However, that's a custom one. For some reasons we
couldn't put the mass storage device to interface 0.

I was wondering about the level of indentation. You confirmed I need
to work on it.

Thanks for your comments, I'll send a v2 soon.

Franck.


More information about the U-Boot mailing list