[U-Boot] [PATCH v6 4/6] arm: spl: Allow board_init_r() to run with a larger stack

Tom Rini trini at konsulko.com
Wed Mar 4 23:16:13 CET 2015


On Tue, Mar 03, 2015 at 08:03:00AM -0700, Simon Glass wrote:

> At present SPL uses a single stack, either CONFIG_SPL_STACK or
> CONFIG_SYS_INIT_SP_ADDR. Since some SPL features (such as MMC and
> environment) require a lot of stack, some boards set CONFIG_SPL_STACK to
> point into SDRAM. They then set up SDRAM very early, before board_init_f(),
> so that the larger stack can be used.
> 
> This is an abuse of lowlevel_init(). That function should only be used for
> essential start-up code which cannot be delayed. An example of a valid use is
> when only part of the SPL code is visible/executable, and the SoC must be set
> up so that board_init_f() can be reached. It should not be used for SDRAM
> init, console init, etc.
> 
> Add a CONFIG_SPL_STACK_R option, which allows the stack to be moved to a new
> address before board_init_r() is called in SPL.
> 
> The expected SPL flow (for CONFIG_SPL_FRAMEWORK) is documented in the README.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> For version 1:
> Acked-by: Albert ARIBAUD <albert.u.boot at aribaud.net>
> Reviewed-by: Stefan Roese <sr at denx.de>
> Tested-by: Bo Shen <voice.shen at atmel.com>
> Acked-by: Bo Shen <voice.shen at atmel.com>
> Acked-by: Heiko Schocher <hs at denx.de>
> Tested-by: Heiko Schocher <hs at denx.de>

After fixing the Kconfig part to not have 'CONFIG_' in the 'config' and
'depends' lines, applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150304/ab1e354a/attachment.sig>


More information about the U-Boot mailing list