[U-Boot] [PATCH 02/22] sandbox: Correct device tree 'reg' properties for I2C and SPI
Simon Glass
sjg at chromium.org
Thu Mar 5 05:09:59 CET 2015
Hi Bin,
On 25 February 2015 at 01:20, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Thu, Feb 19, 2015 at 5:10 AM, Simon Glass <sjg at chromium.org> wrote:
>> These are missing a size value. Add one in each case.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> arch/sandbox/dts/sandbox.dts | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts
>> index 9ce31bf..1ccfdee 100644
>> --- a/arch/sandbox/dts/sandbox.dts
>> +++ b/arch/sandbox/dts/sandbox.dts
>> @@ -144,7 +144,7 @@
>> i2c at 0 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> - reg = <0>;
>> + reg = <0 0>;
>
> Why? Its parent node's #size-cells is 0.
>
>> compatible = "sandbox,i2c";
>> clock-frequency = <400000>;
>> eeprom at 2c {
>> @@ -161,7 +161,7 @@
>> spi at 0 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> - reg = <0>;
>> + reg = <0 0>;
>> compatible = "sandbox,spi";
>> cs-gpios = <0>, <&gpio_a 0>;
>> flash at 0 {
>> --
It is needed by a later patch which changes the size to 1. I will
merge that change in here.
Regards,
Simon
More information about the U-Boot
mailing list