[U-Boot] [PATCH v6 3/6] dm: tegra: Enable driver model in SPL and adjust the GPIO driver

[Simon Glass]

Hi Stephen,

On 9 March 2015 at 11:23, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 03/09/2015 11:04 AM, Simon Glass wrote:
>>
>> Hi Stephen,
>>
>> On 8 March 2015 at 15:00, Stephen Warren <swarren at nvidia.com> wrote:
>>>
>>>
>>> On 03/04/2015 03:16 PM, Tom Rini wrote:
>>>>
>>>> On Tue, Mar 03, 2015 at 08:02:59AM -0700, Simon Glass wrote:
>>>>
>>>>> Use the full driver model GPIO and serial drivers in SPL now that
>>>>> these are supported. Since device tree is not available they will
>>>>> use platform data.
>>>>>
>>>>> Remove the special SPL GPIO function as it is no longer needed.
>>>>>
>>>>> This is all in one commit to maintain bisectability.
>>>>>
>>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>>
>>>>
>>>> Applied to u-boot/master, thanks!
>>>
>>>
>>> This patch breaks the serial console on at least NVIDIA Tegra
>>> Seaboard. LCD/usbkbd still work though. I can't test any other Tegra
>>> boards right now since I'm not at work. I wonder if the UART/SPI GPIO
>>> is at issue? That would be specific to this board.
>>
>>
>> Could be - what do you have it set to? I should be able to give it
>> another test sometime today and nut it out.
>
>
> I assume it must be set to "GPIO control" (especially since a GPIO-related
> change broke it). IIRC it came this way, and since the board boots from NAND
> and hence SPI isn't useful, I was going to change it to "always UART".
> However, when I attempted to modify my other Seaboard (actually, Springbank)
> that way, I broke one of the pads on the PCB. Luckily that left the board in
> the "always UART" state that I wanted, even without any pull-ups/downs
> present. Anyway, I decided not to touch my other board for fear of breaking
> it in a way that didn't work at all!

Yes that's it. I must have tested it with the switch in the other
position. I sent a patch to fix it - the problem is that
gpio_request() needs a GPIO name now.

Regards,
Simon