[U-Boot] [PATCH] misc: led: Add PCA9551 LED driver

Tom Rini trini at konsulko.com
Wed Mar 11 15:40:32 CET 2015


On Wed, Mar 11, 2015 at 09:51:40AM +0100, Stefan Roese wrote:

> This patch adds a driver for the PCA9551 LED controller.
> 
> Originated-by: Timo Herbrecher <t.herbrecher at gateware.de>
> Signed-off-by: Stefan Roese <sr at denx.de>

Reviewed-by: Tom Rini <trini at konsulko.com>

But:

> +struct pca9551_blink_rate {
> +	u8 psc;	/* Frequency preescaler, see PCA9551_7.pdf p. 6 */
> +	u8 pwm;	/* Pulse width modulation, see PCA9551_7.pdf p. 6 */
> +} __packed;

Yes, really, this must be packed because otherwise we get unwanted
padding in between these u8s?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150311/7aaa2f11/attachment.sig>


More information about the U-Boot mailing list