[U-Boot] [PATCH 1/2] pci/layerscape: move pcie_layerscape.h out of arm include

Lian Minghuan-B31939 B31939 at freescale.com
Thu Mar 12 03:21:34 CET 2015


Hi Tom,

Thanks for your comments.
I will use the common name and remove unnecessary file pcie_layerscape.h

Thanks,
Minghuan


On 2015年03月11日 22:22, Tom Rini wrote:
> On Wed, Mar 11, 2015 at 07:09:33PM +0800, Minghuan Lian wrote:
>
>> The patch moves pcie_layerscape.h out of arm include to top
>> level include folder so that it can be shared on other Socs.
>>
>> Signed-off-by: Minghuan Lian <Minghuan.Lian at freescale.com>
> OK, I see a problem:
>
>> diff --git a/arch/arm/include/asm/pcie_layerscape.h b/arch/arm/include/asm/pcie_layerscape.h
>> deleted file mode 100644
>> index fb08578..0000000
>> --- a/arch/arm/include/asm/pcie_layerscape.h
>> +++ /dev/null
>> @@ -1,13 +0,0 @@
>> -/*
>> - * Copyright 2014 Freescale Semiconductor, Inc.
>> - *
>> - * SPDX-License-Identifier:	GPL-2.0+
>> - */
>> -
>> -#ifndef __PCIE_LAYERSCAPE_H_
>> -#define __PCIE_LAYERSCAPE_H_
>> -
>> -void pci_init_board(void);
> This is already in <common.h>
>
>> -void ft_pcie_setup(void *blob, bd_t *bd);
> This belongs in <fdt_support.h> near other similar functions and frankly
> might be better done as ft_pci_setup(blob, bd) which already exists.  Or
> do we have both ft_pci_setup and ft_pcie_setup existing at the same
> time?
>



More information about the U-Boot mailing list