[U-Boot] [PATCH v1 1/4] ARM: DRA7XX: Add config file for Android with fastboot support

[Dileep Katta]

Hi Tom and Lukasz,

On 4 March 2015 at 22:22, Tom Rini <trini at konsulko.com> wrote:

> On Tue, Mar 03, 2015 at 04:40:41PM +0530, Dileep Katta wrote:
>
> > Signed-off-by: Angela Stegmaier <angelabaker at ti.com>
> > Signed-off-by: Dileep Katta <dileep.katta at linaro.org>
> > ---
> >  arch/arm/cpu/armv7/omap5/Kconfig     |   5 +
> >  board/ti/dra7xx/Kconfig              |  13 ++
> >  board/ti/dra7xx/MAINTAINERS          |   2 +
> >  configs/dra7xx_evm_android_defconfig |   5 +
> >  include/configs/dra7xx_evm_android.h | 313
> +++++++++++++++++++++++++++++++++++
> >  5 files changed, 338 insertions(+)
> >  create mode 100644 configs/dra7xx_evm_android_defconfig
> >  create mode 100644 include/configs/dra7xx_evm_android.h
>
> I _really_ don't like how we're duplicating large hunks of dra7xx_evm.h.
> The first question is, what parts of this are not appropriate to just do
> in dra7xx_evm.h directly?  And the second question would be, which of
> those cannot simply be done via Kconfig choices.
>
> --
> Tom
>
Discussed this with Angela from TI, and arrived at a common header file so
that the duplication could be avoided. Will send a follow-up patch with the
update.
Thanks for the comments.

Regards, Dileep