[U-Boot] [PATCH v5 08/14] virt-dt: Allow reservation of secure region when in a RAM carveout

[Jan Kiszka]

Am 2015-03-11 um 16:12 schrieb Tom Rini:
> On Mon, Mar 09, 2015 at 08:00:18AM +0100, Jan Kiszka wrote:
> 
>> In this case the secure code lives in RAM, and hence the memory node in
>> the device tree needs to be adjusted. This avoids that the OS will map
>> and possibly access the reservation.
>>
>> Add support for setting CONFIG_ARMV7_SECURE_RESERVE_SIZE to carve out
>> such a region. We only support cutting off memory from the beginning or
>> the end of a RAM bank as we do not want to increase their number (which
>> would happen if punching a hole) for simplicity reasons
>>
>> This will be used in a subsequent patch for Jetson-TK1.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
>> ---
>>  arch/arm/cpu/armv7/virt-dt.c | 29 +++++++++++++++++++++++++++++
> 
> My concern here is that this looks a lot like things we would re-use on
> armv8 and we're making them potentially needlessly v7-centric.  If
> nothing else, the function names should be generic and this be the v7
> implementation of them, yes?

I didn't look into v8's needs and state yet, so I cannot comment on
this. But my feeling is that renaming is only relevant if we expect PSCI
code that invokes this to be shared by both.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux