[U-Boot] [PATCH] autoboot.c: Add feature to stop autobooting via SHA256 encrypted password

[Simon Glass]

Hi,

On 11 March 2015 at 08:36, Tom Rini <trini at konsulko.com> wrote:
>
> On Wed, Mar 11, 2015 at 09:51:37AM +0100, Stefan Roese wrote:
>
> > This patch adds the feature to only stop the autobooting, and therefor
> > boot into the U-Boot prompt, when the input string / password matches
> > a values that is encypted via a SHA256 hash and saved in the environment.
> >
> > This feature is enabled by defined these config options:
> >      CONFIG_AUTOBOOT_KEYED
> >      CONFIG_AUTOBOOT_STOP_STR_SHA256
> >
> > Signed-off-by: Stefan Roese <sr at denx.de>
>
> This is certainly interesting but I think brings us back to a point
> Simon made a long while back about needing to factor out this code
> better.  Especially since this adds big long #if-#else-#endif blocks.
> Can we re-do this so at least have some functions be called out instead?
> Thanks!
>

Also if these CONFIG options are in Kconfig (as they should be) then we can use

if (IS_ENABLED(CONFIG_AUTOBOOT_STOP_STR_SHA256))

instead of #ifdef which may improve the code.

Regards,
Simon