[U-Boot] [PATCH] sdhci: fix warnings on 64-bit builds

Pantelis Antoniou panto at antoniou-consulting.com
Wed Mar 18 08:55:14 CET 2015


Hi Rob,

> On Mar 17, 2015, at 22:46 , Rob Herring <robh at kernel.org> wrote:
> 
> Change addresses to unsigned long to be compatible with 64-bit builds.
> Regardless of fixing warnings, the device is still only 32-bit capable.
> 
> Signed-off-by: Rob Herring <robh at kernel.org>
> Cc: Pantelis Antoniou <panto at antoniou-consulting.com>
> ---
> drivers/mmc/sdhci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
> index 82d7984..2d92204 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -194,13 +194,13 @@ static int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,
> 
> #ifdef CONFIG_MMC_SDMA
> 		if (data->flags == MMC_DATA_READ)
> -			start_addr = (unsigned int)data->dest;
> +			start_addr = (unsigned long)data->dest;
> 		else
> -			start_addr = (unsigned int)data->src;
> +			start_addr = (unsigned long)data->src;
> 		if ((host->quirks & SDHCI_QUIRK_32BIT_DMA_ADDR) &&
> 				(start_addr & 0x7) != 0x0) {
> 			is_aligned = 0;
> -			start_addr = (unsigned int)aligned_buffer;
> +			start_addr = (unsigned long)aligned_buffer;
> 			if (data->flags != MMC_DATA_READ)
> 				memcpy(aligned_buffer, data->src, trans_bytes);
> 		}
> -- 
> 2.1.0
> 

Thanks, applied.

— Pantelis



More information about the U-Boot mailing list