[U-Boot] [PATCH v2] i2c: mvtwsi: Fix problem with baud rate calculation

Heiko Schocher hs at denx.de
Wed Mar 18 10:14:05 CET 2015


Hello Stefan,

Am 18.03.2015 09:30, schrieb Stefan Roese:
> The current implementation for baudrate calculation is incorrect.
> This part from the formula:
>
> "2 ^ (n + 1)" is not equivalent to (1 << n) but to (2 << n)!
>
> This patch fixes this and moves this calculation to a function instead of using a macro.
> This new function is taken from the Linux kernel.
>
> This was detected and tested on the Marvell Armada A38x DB-88F6820-GP eval board.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Prafulla Wadaskar <prafulla at marvell.com>
> Cc: Luka Perkov <luka.perkov at sartura.hr>
> Cc: Hans de Goede <hdegoede at redhat.com>
> Cc: Ian Campbell <ijc at hellion.org.uk>
> Cc: Heiko Schocher <hs at denx.de>
> ---
> v2:
> - Still use the old formula for SUNXI, as this was checked
>    by Hans with Allwinner to be the correct formula. This means
>    that the Linux baudrate is incorrect for SUNXI I2C though.
>
>   drivers/i2c/mvtwsi.c | 17 +++++++++--------
>   1 file changed, 9 insertions(+), 8 deletions(-)

Thanks!

Applied to u-boot-i2c.git

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list