[U-Boot] [PATCH v2 3/4] common/lcd_console: move single static variables into common (static) structure

Hannes Petermaier hannes at petermaier.org
Wed Mar 18 13:14:14 CET 2015


On 2015-03-18 13:11, Igor Grinberg wrote:
> [...]
>> +struct console_t {
>> +	short curr_col, curr_row;
>> +	short cols, rows;
>> +	void *lcd_address;
> Shouldn't this be fbbase?
>
>> +};
>> +static struct console_t cons;
> [...]
>
Hi Igor,
my plan was/is to make a cleanup patch after this story is closed.
- remove empty lines in code
- rename some variables

would it be better to do that immediately ?

best regards,
Hannes



More information about the U-Boot mailing list