[U-Boot] [PATCH v2 1/1] ARM: DRA7XX: Add config file for Android with fastboot support

[Dileep Katta]

Hi Tom,

On 18 March 2015 at 21:41, Tom Rini <trini at konsulko.com> wrote:

> On Wed, Mar 18, 2015 at 12:08:23AM +0530, Dileep Katta wrote:
>
> >       - Added new configuration for Android fastboot
> >       - This is based on following patch modified accordingly
> >
> http://git.omapzoom.org/?p=repo/u-boot.git;a=commit;h=b2e04f92b5d91c708b6fd6b79d2266966ac51f4b
> >
> > Signed-off-by: Angela Stegmaier <angelabaker at ti.com>
> > Signed-off-by: Dileep Katta <dileep.katta at linaro.org>
> [snip]
> > @@ -43,6 +43,16 @@
> >       "uuid_disk=${uuid_gpt_disk};" \
> >       "name=rootfs,start=2MiB,size=-,uuid=${uuid_gpt_rootfs}"
> >
> > +#ifdef CONFIG_DRA7XX_ANDROID
> > +/* Fastboot */
> > +#define CONFIG_CMD_FASTBOOT
> > +#define CONFIG_ANDROID_BOOT_IMAGE
> > +#define CONFIG_USB_FASTBOOT_BUF_ADDR    CONFIG_SYS_LOAD_ADDR
> > +#define CONFIG_USB_FASTBOOT_BUF_SIZE    0x2F000000
> > +#define CONFIG_FASTBOOT_FLASH
> > +#define CONFIG_FASTBOOT_FLASH_MMC_DEV   1
> > +#endif
> > +
> >  #include <configs/ti_omap5_common.h>
>
> No, just enable fastboot.  There's a growing population of people whose
> workflow is "use fastboot to shove a new test kernel at my device" that
> aren't strictly using Android, lets enable them.
>
OK, will enable fastboot unconditional.
Now there is no much difference for android_defconfig, but will still keep
separate config for future changes.

>
> > @@ -115,7 +125,11 @@
> >  #define CONFIG_SPL_SPI_SUPPORT
> >  #define CONFIG_SPL_SPI_LOAD
> >  #define CONFIG_SPL_SPI_FLASH_SUPPORT
> > +#ifdef CONFIG_DRA7XX_ANDROID
> > +#define CONFIG_SYS_SPI_U_BOOT_OFFS     0x80000
> > +#else
> >  #define CONFIG_SYS_SPI_U_BOOT_OFFS     0x40000
> > +#endif
>
> Why are you moving U-Boot so much higher in SPI flash?
>
This is done to accommodate  larger size MLO.

>
> > @@ -130,6 +144,22 @@
> >  #define CONFIG_OMAP_USB_PHY
> >  #define CONFIG_OMAP_USB2PHY2_HOST
> >
> > +/* USB GADGET */
> > +#define CONFIG_USB_GADGET
> > +#define CONFIG_MUSB_GADGET
> > +#define CONFIG_MUSB_PIO_ONLY
>
> This board doesn't have MUSB, DWC3 only.
>
Thanks. DWC3 is enabled in dwc3_gadget developer branch of DFU custodian
tree.
Will submit the updated patch on top of the same

>
> > +#define CONFIG_USBDOWNLOAD_GADGET
> > +#define CONFIG_USB_GADGET_VBUS_DRAW 2
> > +#define CONFIG_G_DNL_MANUFACTURER "Texas Instruments"
> > +#ifdef CONFIG_CMD_FASTBOOT
> > +#define CONFIG_G_DNL_VENDOR_NUM 0x0451
> > +#define CONFIG_G_DNL_PRODUCT_NUM 0xd022
> > +#else
> > +#define CONFIG_G_DNL_VENDOR_NUM 0x0403
> > +#define CONFIG_G_DNL_PRODUCT_NUM 0xBD00
> > +#endif
> > +#define CONFIG_USB_GADGET_DUALSPEED
>
> Why can't we always use one vid/pid?
>
As we are restricted to use the vid which fastboot host application knows,
the other/original
vid/pid kept intact for the dependent functionality, if any.
Will check if 0x0403/0xBD00 could be removed.

>
> --
> Tom
>
Regards, Dileep