[U-Boot] [PATCH v6 09/27] net: Remove the bd* parameter from net stack functions

Joe Hershberger joe.hershberger at gmail.com
Sun Mar 22 04:42:14 CET 2015


Hi Simon,

On Fri, Mar 20, 2015 at 6:01 PM, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Joe,
>
> On 11 March 2015 at 17:44, Joe Hershberger <joe.hershberger at ni.com> wrote:
> > This value is not used by the network stack and is available in the
> > global data, so stop passing it around.  For the one legacy function
> > that still expects it (init op on old Ethernet drivers) pass in the
> > global pointer version directly to avoid changing that interface.
> >
> > Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> > Reported-by: Simon Glass <sjg at chromium.org>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > ---
> >
> > Changes in v6:
> > -Fix compile errors for other boards due to removed parameters
>
> Unfortunately this causes several build failures:
>
> 38: net: Remove the bd* parameter from net stack functions
>    powerpc:  +   PLU405 PMC440 sc3 neo acadia csb472 devconcenter
> sequoia arches lwmon5 t3corp walnut PMC405DE redwood katmai
> gdppc440etx p3p440 sycamore MIP405 zeus rainier_ramboot canyonlands
> MIP405T haleakala dlvision csb272 xpedite1000 io yosemite yucca makalu
> sequoia_ramboot dlvision-10g pcs440ep CPCI4052 sbc405 iocon ebony
> glacier_ramboot VOM405 bamboo luan io64 PIP405 intip glacier
> lcd4_lwmon5 bubinga yellowstone icon kilauea rainier
>
> e.g:
>
> $ buildman -b dm-push -s PLU405 -e
> ...
> 38: net: Remove the bd* parameter from net stack functions
>   powerpc:  +   PLU405
> +../drivers/net/4xx_enet.c: In function 'mal_err':
> +../drivers/net/4xx_enet.c:1734:2: error: too many arguments to
> function 'eth_init'
> +../include/net.h:169:5: note: declared here
> +make[2]: *** [drivers/net/4xx_enet.o] Error 1
> +make[1]: *** [drivers/net] Error 2
> +make: *** [sub-make] Error 2
> ...
>
> Can you please check this and respin?

Sorry about that. Are you aware of anything other than the 4xx_enet.c
error? I grepped around and didn't find anything else, but I also missed
this one previously using the same method.

Thanks,
-Joe


More information about the U-Boot mailing list