[U-Boot] [PATCH] sunxi: axp221: Use vbus-available rather then vbus-usable for vbus-detect

Hans de Goede hdegoede at redhat.com
Mon Mar 23 17:38:19 CET 2015


Hi,

On 23-03-15 17:33, Paul Kocialkowski wrote:
> Le lundi 23 mars 2015 à 17:28 +0100, Hans de Goede a écrit :
>> vbus-usable does not get set if power is provided through the power barrel
>> connector, even if external 5v is also present on the otg connector.
>>
>> vbus-available correctly always reflects if there is 5v present on the otg
>> connector.
>
> You (or I) could submit the very same change for the AXP209. It's the
> same bit for available (1 << 5).

Yes I was about to mail you about that when I noticed that this seems to
break actual host mode support on the otg connector, it seems that
plugging in a micro-b to usb-a receptacle (aka host) convertor + a device
plugged into the usb-a receptacle also causes bit 5 to get set :|

So my patch is no good, but powering the otg port while external 5v is present
also is not good (one side effect is that the tablet will power up immediately
after sending a power-off command to the axp221).

If you've some time to tinker with this I would appreciate any ideas
you may have (assuming the same problem exists on the axp209)
simply plug in 5v power into the power barrel, as well as 5v power
(e.g. simply from your pc) and boot up the tablet, at least in my
case then it does not properly give the charger plugged in error.

Regards,

Hans



>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>   drivers/power/axp221.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/axp221.c b/drivers/power/axp221.c
>> index f758a75..dc3a7f1 100644
>> --- a/drivers/power/axp221.c
>> +++ b/drivers/power/axp221.c
>> @@ -424,7 +424,7 @@ int axp_gpio_get_value(unsigned int pin)
>>   		if (ret)
>>   			return ret;
>>
>> -		return !!(val & AXP221_POWER_STATUS_VBUS_USABLE);
>> +		return !!(val & AXP221_POWER_STATUS_VBUS_AVAIL);
>>   	default:
>>   		return -EINVAL;
>>   	}
>


More information about the U-Boot mailing list