[U-Boot] [PATCH 2/3] Kconfig: i2c: remove wrong help message related to dm i2c

Przemyslaw Marczak p.marczak at samsung.com
Thu Mar 26 14:18:36 CET 2015


Hello Simon,

On 03/24/2015 12:39 AM, Simon Glass wrote:
> Hi,
>
> On 10 March 2015 at 04:30, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
>> Cc: Masahiro Yamada <yamada.m at jp.panasonic.com>
>> Cc: Mike Frysinger <vapier at gentoo.org>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Heiko Schocher <hs at denx.de>
>> ---
>>   drivers/i2c/Kconfig | 11 +----------
>>   1 file changed, 1 insertion(+), 10 deletions(-)
>>
>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
>> index 692810d..0a52ed9 100644
>> --- a/drivers/i2c/Kconfig
>> +++ b/drivers/i2c/Kconfig
>> @@ -2,16 +2,7 @@ config DM_I2C
>>          bool "Enable Driver Model for I2C drivers"
>>          depends on DM
>>          help
>> -         Enable driver model for I2C. This SPI flash interface
>> -         (spi_flash_probe(), spi_flash_write(), etc.) is then
>> -         implemented by the SPI flash uclass. There is one standard
>> -         SPI flash driver which knows how to probe most chips
>> -         supported by U-Boot. The uclass interface is defined in
>> -         include/spi_flash.h, but is currently fully compatible
>> -         with the old interface to avoid confusion and duplication
>> -         during the transition parent. SPI and SPI flash must be
>> -         enabled together (it is not possible to use driver model
>> -         for one and not the other).
>> +         Enable driver model for I2C.
>
> That's too short IMO :-)
>
> Can you add a few more details along the lines of what is described
> for SPI, and also mention the COMPAT option?
>
> Thanks for fixing this.
>

Ok, will add more details :)

>>
>>   config DM_I2C_COMPAT
>>          bool "Enable I2C compatibility layer"
>> --
>> 1.9.1
>>
>
> Regards,
> Simon
>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com


More information about the U-Boot mailing list